Gnome Shell < 3.34 support #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example RHEL 8 with 3.32.2. ModalDialog was converted to GObject.registerClass in 3.34. Fixes #48 Signed-off-by: NVieville <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch from @NVieville.
Add compatibility with Gnome-Shell < 3.34 to the
pre-45branch.For example RHEL 8 with 3.32.2. ModalDialog was converted to GObject.registerClass in 3.34.
Fixes #48
(paradoxxxzero PR: paradoxxxzero#790)
Testing (help needed)
Before merging this I'd like to get some testing results. I don't have any legacy GS installs laying around so would appreciate it if somebody else who does could test and post results. Please include screenshots of the extension running along with the Gnome Shell version in the About -> System Details window (example below).
Example screenshot
This change is