Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Gnome-Shell < 3.34 on branch pre-45 - RHEL 8 related #48

Open
NVieville opened this issue Nov 4, 2023 · 0 comments

Comments

@NVieville
Copy link

Hello,

I wonder if you could review and, if appropriated apply the pull request made to upstream repository:

paradoxxxzero#790

It's about keeping compatibility with old gnome-shell versions, specially for RHEL 8 actually
used by some users. It would be great to have it in the pre-45 branch of your repository.

As I maintain the Fedora package of this great gnome-shell extension, I'm thinking of
switching the sources of this package to your fork of the historical/upstream repository for
all the packaged versions of this extension. As you applied some pull request coming
from the upstream repository (gnome-shell 44 compatibility for example) to your
pre-45 branch, I wonder if this could be the same for some other pull requests.

Feel free to make any comment about this pull-request/issue (I didn't know how to do it).
Thanks for taking this extension to gnome-shell 45.

Cordially,

--
NVieville

mgalgs pushed a commit that referenced this issue Nov 7, 2023
For example RHEL 8 with 3.32.2. ModalDialog was converted to
GObject.registerClass in 3.34.

Fixes #48

Signed-off-by: NVieville <[email protected]>
@mgalgs mgalgs mentioned this issue Nov 7, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant