Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Rose Packaging PR #2358

Closed
wants to merge 14 commits into from

Conversation

wxtim
Copy link
Contributor

@wxtim wxtim commented Jun 17, 2019

Make rose a PyPi package.

Steps

  • Convert Rose into a PyPi package and get the local tests running.
  • Convert Rosie into a PyPi package (this will contain a dependency on rose).
  • Replace the bin directory with wrappers scripts created by the setup file.
  • Make the tests run on Travis.

Problems

Currently waiting on fixes to Rosie on master: PR #2355 before rebase.

bin/rose-app-run Outdated
@@ -18,10 +18,10 @@
# along with Rose. If not, see <http://www.gnu.org/licenses/>.
#-------------------------------------------------------------------------------
# NAME
# rose app-run
# metomi.rose app-run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search and replace? The command is still rose app-run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ay!

#
# [rose-config-diff]properties, [rose-config-diff]ignore{...}
# [metomi.rose-config-diff]properties, [rose-config-diff]ignore{...}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More search and replace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oc.

@oliver-sanders
Copy link
Member

Turns out we can auto-upgrade import rose to import metomi.rose in a few lines piggybacking on the 2to3 command.

I've stuck up a repo which may be of assistance to people upgrading Rose Macros etc. As and when we make changes just stick a new transformer in here:

https://github.com/oliver-sanders/rose2to3

@wxtim wxtim force-pushed the yet-another-rose-package-branch branch from 3cbed83 to 50ba8d6 Compare June 21, 2019 08:22
@wxtim wxtim force-pushed the yet-another-rose-package-branch branch from 3f73011 to 99d72ae Compare June 21, 2019 10:45
@wxtim wxtim closed this Jun 25, 2019
@wxtim
Copy link
Contributor Author

wxtim commented Jun 25, 2019

Closed in favour of #2360

@matthewrmshin matthewrmshin removed this from the next-feature-alpha milestone Jun 25, 2019
@wxtim wxtim deleted the yet-another-rose-package-branch branch July 25, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants