Add MIRRORD_IMPERSONATED_CONTAINER_NAME var #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This CR adds an optional
MIRRORD_IMPERSONATED_CONTAINER_NAME
to specify container name within pod for #100.This doesn't implement ignoring linkerd/envoy pods yet. Can iterate on this draft based on feedback. I suppose the best way to ignore containers like this is to filter out common container names for linkerd/envoy within a pod?
A couple things that are missing, I'll convert to draft if these are blockers.
Testing
These are low effort tests and not really best practice since they won't be in CI. I can try this weekend adding a mock failure run to sanity.rs.
MIRRORD_IMPERSONATED_CONTAINER_NAME=test
(link)MIRRORD_IMPERSONATED_CONTAINER_NAME
(link)MIRRORD_IMPERSONATED_CONTAINER_NAME=testgarbage
(link)Example failure:
https://github.com/camerondurham/mirrord/runs/7167505799?check_suite_focus=true#step:15:76
Thanks!