-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify container name to impersonate #100
Comments
I'd like to work on this issue. Thanks! |
Great! Let us know if you need any help 😊 |
Thanks @camerondurham . I'm updating the ticket to reflect what needs to be added. |
@camerondurham Do you you wish to contribute the other open items as well? (making sure the assigned state is correct ;) ) |
Hey @aviramha, I'm interested in finishing the other tasks as well if that's alright! I was running into a bug with the extension selection so sending the draft PR for now and can provide more context in |
That's more than alright! Feel free to consult with us on |
@camerondurham |
@aviramha Following up from convo in I can help with minor changes to fix existing features added but if it's more than a couple days work I probably won't have time. What I've done so far:
Thanks for following up, I should've asked this sooner! |
Thanks @camerondurham - My fault for not tracking the issues/linking to this. |
Today, we pick up the first container in the pod we impersonate. This might not be the case for service mesh setups or more elaborate setups, so we need to let the user specify container name and maybe add a warning when we just assume and use the first one.
Also, we should consider ignoring linkerd/envoy containers by default (unless specified?)
Edit:
Status:
The text was updated successfully, but these errors were encountered: