Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify container name to impersonate #100

Closed
3 tasks done
aviramha opened this issue May 31, 2022 · 9 comments
Closed
3 tasks done

Add ability to specify container name to impersonate #100

aviramha opened this issue May 31, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed ux

Comments

@aviramha
Copy link
Member

aviramha commented May 31, 2022

Today, we pick up the first container in the pod we impersonate. This might not be the case for service mesh setups or more elaborate setups, so we need to let the user specify container name and maybe add a warning when we just assume and use the first one.
Also, we should consider ignoring linkerd/envoy containers by default (unless specified?)
Edit:

Status:

  • @camerondurham added basic functionality controlled by env var.
  • Need to expose that functionality from the cli
  • ^^ VS Code Extension
@aviramha aviramha added enhancement New feature or request help wanted Extra attention is needed ux labels May 31, 2022
@camerondurham
Copy link
Contributor

I'd like to work on this issue. Thanks!

@aviramha
Copy link
Member Author

aviramha commented Jul 1, 2022

I'd like to work on this issue. Thanks!

Great! Let us know if you need any help 😊

@aviramha
Copy link
Member Author

aviramha commented Jul 3, 2022

Thanks @camerondurham . I'm updating the ticket to reflect what needs to be added.

@aviramha
Copy link
Member Author

aviramha commented Jul 4, 2022

@camerondurham Do you you wish to contribute the other open items as well? (making sure the assigned state is correct ;) )

@camerondurham
Copy link
Contributor

Hey @aviramha, I'm interested in finishing the other tasks as well if that's alright! I was running into a bug with the extension selection so sending the draft PR for now and can provide more context in #dev too...

@aviramha
Copy link
Member Author

aviramha commented Jul 4, 2022

That's more than alright! Feel free to consult with us on #dev

@aviramha
Copy link
Member Author

@camerondurham
Hey, are you still working on this issue? No pressure :) Just so we can mark this as available for others if not.

@camerondurham
Copy link
Contributor

@aviramha Following up from convo in#dev.

I can help with minor changes to fix existing features added but if it's more than a couple days work I probably won't have time.

What I've done so far:

  1. (PR Add MIRRORD_IMPERSONATED_CONTAINER_NAME var #182) Added a flag to the CLI in (here: https://github.com/metalbear-co/mirrord/pull/182/files#diff-e7e961df0a87503db868f6db719d10b5f06c962d7b1939079055514a118844bc)
  2. (PR Add quickselect for impersonated container name, fix CLI env var name #185) Added another quickselect window to the VSCode extension when starting to debug (here: https://github.com/metalbear-co/mirrord/pull/185/files#diff-71da5b8ace00ececa231c3f58ec52d2876a05efaf23404acf1c24cbebbad2bea)

Thanks for following up, I should've asked this sooner!

@aviramha
Copy link
Member Author

Thanks @camerondurham - My fault for not tracking the issues/linking to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed ux
Projects
None yet
Development

No branches or pull requests

2 participants