-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split codetracer.nim into multiple files and remove orphaned functions #24
Conversation
…s, removed obsolete functionality and added some Windows code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good: we discussed/looked at most of the changes them privately before opening the PR, so I agree with most of the refactoring; additional improvements and fixes might be part of new PR-s; several small things to fix required
…s and move startCore to backends
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, looks much better after the refactoring!
This is the start of a movement to refactor the way codetracer is launched. This PR splits the current monolithic
codetracer.nim
file into 17 files and removes a number of orphaned functions along the way.A further functional refactor can be done in a followup PR, since there is a lot to untangle. This PR should make this process significantly easier though!
It also adds on the documentation, adding all environment variables that are exposed by
codetracer.nim