Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split codetracer.nim into multiple files and remove orphaned functions #24

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

Madman10K
Copy link
Contributor

This is the start of a movement to refactor the way codetracer is launched. This PR splits the current monolithic codetracer.nim file into 17 files and removes a number of orphaned functions along the way.

A further functional refactor can be done in a followup PR, since there is a lot to untangle. This PR should make this process significantly easier though!

It also adds on the documentation, adding all environment variables that are exposed by codetracer.nim

@Madman10K Madman10K added documentation Improvements or additions to documentation refactor A system was refactored labels Mar 8, 2025
@Madman10K Madman10K requested review from alehander92 and pxor March 8, 2025 21:41
@Madman10K Madman10K self-assigned this Mar 8, 2025
@cla-bot cla-bot bot added the cla-signed label Mar 8, 2025
Copy link
Contributor

@alehander92 alehander92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good: we discussed/looked at most of the changes them privately before opening the PR, so I agree with most of the refactoring; additional improvements and fixes might be part of new PR-s; several small things to fix required

@alehander92 alehander92 self-requested a review March 10, 2025 13:58
Copy link
Contributor

@alehander92 alehander92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, looks much better after the refactoring!

@alehander92 alehander92 merged commit 2f791cb into main Mar 10, 2025
13 checks passed
@alehander92 alehander92 deleted the entry-point-refactor-2 branch March 10, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation refactor A system was refactored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants