refactor(src/codetracer.nim): fix alexander's nitpicks about new lines and move startCore to backends

Author: Madman10K

src/ct/cli/help.nim

@@ -6,4 +6,4 @@ proc displayHelp*: void =
   # echo "help: TODO"
   let process = startProcess(codetracerExe, args = @["--help"], options = {poParentStreams})
   let code = waitForExit(process)
-  quit(code)
+  quit(code)

src/ct/cli/list.nim

@@ -46,4 +46,4 @@ proc listCommand*(rawTarget: string, rawFormat: string) =
     listLocalTraces(format)
   of ListTarget.Remote:
     echo "error: unsupported currently!"
-    # listRemoteTraces(format)
+    # listRemoteTraces(format)

src/ct/cli/logging.nim

@@ -4,4 +4,4 @@ template errorMessage*(message: string) =
   echo message
 
 proc notSupportedCommand*(commandName: string) =
-  echo fmt"{commandName} not supported with this backend"
+  echo fmt"{commandName} not supported with this backend"

src/ct/codetracer.nim

@@ -12,4 +12,5 @@ try:
 except Exception as ex:
   echo "Unhandled exception"
   echo getStackTrace(ex)
-  error "error: unhandled " & ex.msg
+  error "error: unhandled " & ex.msg
+

src/ct/globals.nim

@@ -12,4 +12,4 @@ let
 # after validation
 var replayInteractive* = false
 var electronPid*: int = -1
-var rrPid* = -1 # global, so it can be updated immediately on starting a process, and then used in `onInterrupt` if needed
+var rrPid* = -1 # global, so it can be updated immediately on starting a process, and then used in `onInterrupt` if needed

src/ct/launch/backends.nim

@@ -0,0 +1,28 @@
+import
+  std/[strformat, strutils, osproc],
+  ../../common/[start_utils, types, trace_index],
+  ../utilities/[env],
+  ../cli/[logging],
+  cleanup
+
+proc startCore*(traceArg: string, callerPid: int, test: bool) =
+  # start_core <trace-program-pattern> <caller-pid> [--test]
+  let recordCore = envLoadRecordCore()
+  var trace: Trace = nil
+  try:
+    let traceId = traceArg.parseInt
+    trace = trace_index.find(traceId, test=test)
+  except ValueError:
+    trace = trace_index.findByProgramPattern(traceArg, test=test)
+  except CatchableError as e:
+    errorMessage fmt"start core loading trace error: {e.msg}"
+    quit(1)
+
+  if trace.isNil:
+    echo "error: start core: trace not found for ", traceArg
+    quit(1)
+  # echo trace.repr
+  let process = startCoreProcess(traceId = trace.id, recordCore=recordCore, callerPid=callerPid, test=test)
+  let code = waitForExit(process)
+  discard code
+  stopCoreProcess(process, recordCore)

src/ct/launch/cleanup.nim

@@ -63,4 +63,4 @@ onSignal(SIGINT):
 
 onSignal(SIGTERM):
   cleanup()
-  quit(0)
+  quit(0)

src/ct/launch/launch.nim

@@ -9,30 +9,8 @@ import
   ../globals,
   cleanup,
   electron,
-  results
-
-# TODO: QA Note: move to separate file
-proc startCore*(traceArg: string, callerPid: int, test: bool) =
-  # start_core <trace-program-pattern> <caller-pid> [--test]
-  let recordCore = envLoadRecordCore()
-  var trace: Trace = nil
-  try:
-    let traceId = traceArg.parseInt
-    trace = trace_index.find(traceId, test=test)
-  except ValueError:
-    trace = trace_index.findByProgramPattern(traceArg, test=test)
-  except CatchableError as e:
-    errorMessage fmt"start core loading trace error: {e.msg}"
-    quit(1)
-
-  if trace.isNil:
-    echo "error: start core: trace not found for ", traceArg
-    quit(1)
-  # echo trace.repr
-  let process = startCoreProcess(traceId = trace.id, recordCore=recordCore, callerPid=callerPid, test=test)
-  let code = waitForExit(process)
-  discard code
-  stopCoreProcess(process, recordCore)
+  results,
+  backends
 
 proc runInitial*(conf: CodetracerConf) =
   # TODO should this be here?
@@ -166,4 +144,4 @@ proc runInitial*(conf: CodetracerConf) =
         conf.traceMetadataProgramArg, conf.traceMetadataRecordPidArg,
         conf.traceMetadataRecent,
         conf.traceMetadataRecentLimit,
-        conf.traceMetadataTest)
+        conf.traceMetadataTest)

src/ct/trace/metadata.nim

@@ -26,4 +26,4 @@ proc traceMetadata*(
     let traces = trace_index.findRecentTraces(limit=recentLimit, test)
     echo Json.encode(traces)
   else:
-    echo "null"
+    echo "null"

src/ct/trace/replay.nim

@@ -44,4 +44,4 @@ proc replay*(
   traceFolderArg: Option[string],
   interactive: bool
 ): bool =
-  internalReplayOrUpload(patternArg, traceIdArg, traceFolderArg, interactive, command=StartupCommand.replay)
+  internalReplayOrUpload(patternArg, traceIdArg, traceFolderArg, interactive, command=StartupCommand.replay)

src/ct/trace/run.nim

@@ -67,4 +67,4 @@ proc run*(programArg: string, args: seq[string]) =
     recordCore=recordCore,
     lang=lang,
     recordArgs=recordArgs
-  )
+  )

src/ct/trace/storage_and_import.nim

@@ -159,4 +159,4 @@ proc importDbTrace*(
 
 proc uploadTrace*(trace: Trace) =
   echo "error: uploading traces not supported currently!"
-  quit(1)
+  quit(1)

src/ct/utilities/git.nim

@@ -14,4 +14,4 @@ proc getGitTopLevel*(dir: string): string =
     if exitCode == 0 and output.len > 0:
       return output
   except:
-    return ""
+    return ""