-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated inline vllm inference provider #880
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful PR, thank you!
I have a few comments inline.
All the code review comments should be addressed now. Would one of the project leads mind having another look at the current change set before I merge changes from main into this branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Co-authored-by: Sébastien Han <[email protected]>
Co-authored-by: Sébastien Han <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks for addressing the comments! 🥳
Thanks! Could you also help attach the results from unit tests in 'tests/client-sdk/inference' & 'tests/client-sdk/agents'? |
@frreiss sorry this PR has gone stale again partly due to us on the review side and now it has a few non-trivial conflicts. I tried to resolve some but it is not super straightforward. I wonder if you could take a pass at it soon and we will be sure to merge it relatively quick. |
@ashwinb sure, I'll have a look today. Work might flow into Monday. |
Results from
Embedding tests fail because embeddings on inline vLLM were not implemented before this PR and are still not implemented after this PR. Tests of image inference fail due to some strange behavior in Llama Stack's handling of image input. Specifically, the current implementation of chat_completion_request_to_prompt(), when fed a request containing an image, converts that request to an array of tokens containing image placeholder tokens with token ID 128256. Then |
Results from
Tests involving web search, retrieval, and code execution fail because my environment doesn't have those tools. Other tests pass. |
What does this PR do?
This PR updates the inline vLLM inference provider in several significant ways:
.../models
API instead of hard-coding the model's full name into the provider's YAML configuration.chat_completions
API to a captive (i.e. called directly in-process, not via HTTPS) instance of vLLM's OpenAI-compatible server .logprobs
parameter and completions API are also working.Test Plan
Existing tests in
llama_stack/providers/tests/inference/test_text_inference.py
have good coverage of the new functionality. These tests can be invoked as follows:Sources
Before submitting
Pull Request section?