pdns: fix usage of notify only when zone kind is Master or Slave (go-…

…acme#1780)
melck · Dec 7, 2022 · 74209d0 · 74209d0
1 parent c754882
commit 74209d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/providers/dns/pdns/client.go b/providers/dns/pdns/client.go
@@ -28,6 +28,7 @@ type hostedZone struct {
 	ID     string  `json:"id"`
 	Name   string  `json:"name"`
 	URL    string  `json:"url"`
+	Kind   string  `json:"kind"`
 	RRSets []rrSet `json:"rrsets"`
 
 	// pre-v1 API

diff --git a/providers/dns/pdns/pdns.go b/providers/dns/pdns/pdns.go
@@ -173,7 +173,7 @@ func (d *DNSProvider) Present(domain, token, keyAuth string) error {
 		return fmt.Errorf("pdns: %w", err)
 	}
 
-	if d.apiVersion < 1 {
+	if d.apiVersion < 1 || (zone.Kind != "Master" && zone.Kind != "Slave") {
 		return nil
 	}
 
@@ -221,7 +221,7 @@ func (d *DNSProvider) CleanUp(domain, token, keyAuth string) error {
 		return fmt.Errorf("pdns: %w", err)
 	}
 
-	if d.apiVersion < 1 {
+	if d.apiVersion < 1 || (zone.Kind != "Master" && zone.Kind != "Slave") {
 		return nil
 	}