Add the scale metadata to the output_stores #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziw-liu
reviewed
Jun 13, 2024
ziw-liu
reviewed
Jun 13, 2024
ziw-liu
reviewed
Jun 13, 2024
|
@edyoshikun I forgot that there is a runtime-only reference of the datamodule from the trainer... So I removed the API change. Can you test and update OP? |
edyoshikun
commented
Jun 13, 2024
ziw-liu
approved these changes
Jun 13, 2024
ziw-liu
added this to the v0.1.0 release - related to mantis paper, robust VS preprint, and DL@MBL exercise milestone
edyoshikun
added a commit
that referenced
this pull request
Jun 18, 2024
* add the scale metadata from the input. * add change to config file * adding a try except * passing None for default behaviour and letting iohub handle the scale default. * making default metadta_store to none and adding letting iohub handle the exceptions * fix docstring * fix type hint * read input store directly * revert change to the example config --------- Co-authored-by: Ziwen Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds the scale metadata to the output stores.
This is solution requires one to add an input_metadata_store that has the proper scale.