Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS predictions should output the correct voxel_size/scale #62

Closed
edyoshikun opened this issue Dec 4, 2023 · 2 comments
Closed

VS predictions should output the correct voxel_size/scale #62

edyoshikun opened this issue Dec 4, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@edyoshikun
Copy link
Contributor

One inconvenient step in the mantis analysis pipeline is having to go and remember to change the scale metadata on the virtually stained predictions. Is it possible to write the input dataset's scale as the output scale?

@ziw-liu
Copy link
Collaborator

ziw-liu commented Dec 8, 2023

It could be done. The reason why it was omitted is that the prediction writer is currently written as a subclass of the lightning.pytorch.callbacks.BasePredictionWriter callback. This means that all the information it receives at runtime comes from the batch. So the scale information would have to be packed into the batch data, which introduces a small GPU syncing overhead.

@ziw-liu
Copy link
Collaborator

ziw-liu commented Jul 1, 2024

Fixed in #89 and #93.

@ziw-liu ziw-liu closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants