Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor cli #198

Merged
merged 29 commits into from
Oct 19, 2021
Merged

Feature/refactor cli #198

merged 29 commits into from
Oct 19, 2021

Conversation

hiroshi-matsuda-rit
Copy link
Contributor

#190

Change

  • add simple unit tests
    • run test via python setup.py test
  • add type hints
  • move Analyzer, analyzer_* function from command_line.py to analyzer.py
  • refactor command_line::run
    • impl _Outputwrapper to simplify json output process
    • nest was too deep, so cut out main process to functions
    • modify data loader to simplify control flow of analyze_parallel
  • fix small bugs:
    • close called on sys.stdout
    • try to pickle generator(analyze_connlu, analyze_json) when run on parallel

Copy link
Contributor Author

@hiroshi-matsuda-rit hiroshi-matsuda-rit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全てキレイにリファクタいただいて素晴らしいです。
テストの例文についてお願いなのですが、
できれば銀座感を醸し出していただけると、コードを見る人たちも楽しめて良いと思います。

@r-terada
Copy link
Collaborator

追加の commit について LGTM です. (一旦別でファイル読まずに eb3d9a1 のようにした方が効率的ですね 👍 )

@r-terada
Copy link
Collaborator

hash_comment='skip' の場合の返り値が Iterable[Iterable[Iterable]] になっていて, json 出力が失敗していたので eb9993d で修正しました.

@hiroshi-matsuda-rit
Copy link
Contributor Author

hash_comment='skip' の場合の返り値が Iterable[Iterable[Iterable]] になっていて, json 出力が失敗していたので eb9993d で修正しました.

デグレードを修正いただき有難うございました。

hiroshi-matsuda-rit and others added 2 commits October 20, 2021 00:10
…lt_to_c

ginza/ginzame command の split mode の default を "C" に変更する
ginza command line options の doc を追記
@r-terada r-terada merged commit bbda75c into develop Oct 19, 2021
@hiroshi-matsuda-rit hiroshi-matsuda-rit deleted the feature/refactor_cli branch December 16, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants