Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/refactor cli #194

Merged
merged 20 commits into from
Oct 15, 2021
Merged

Feature/refactor cli #194

merged 20 commits into from
Oct 15, 2021

Conversation

r-terada
Copy link
Collaborator

#190

Change

  • add simple unit tests
    • run test via python setup.py test
  • add type hints
  • move Analyzer, analyzer_* function from command_line.py to analyzer.py
  • refactor command_line::run
    • impl _Outputwrapper to simplify json output process
    • nest was too deep, so cut out main process to functions
    • modify data loader to simplify control flow of analyze_parallel
  • fix small bugs:
    • close called on sys.stdout
    • try to pickle generator(analyze_connlu, analyze_json) when run on parallel

r-terada and others added 20 commits October 11, 2021 03:52
@r-terada
add tests for cli
dab7ae5
@r-terada
fix format
8bc1496
@r-terada
delete requirements-dev
a34f3cd
@r-terada
Merge pull request #1 from r-terada/feature/test_cli
49e47aa 
add integration tests for cli
@r-terada
cut out analyzer from command_line
7614446
@r-terada
format accoding to PEP8
ebbd9f7
@r-terada
add test for multiple input files
fd2374e
@r-terada
add typehints to cli and analyzer
8c6e67f
@r-terada
add tests for analyzer
5186d58
@r-terada
Merge pull request #3 from r-terada/feature/cutout_analyzer_from_cli
f57512c 
cutout analyzer from cli
@r-terada
format by black and fix some type hints
46528f3
@r-terada
add tests about run on parallel
01bda83
@r-terada
fix: stop to close sys.stdout
be2c7c3 
it raises IOError when run called more than twice
@r-terada
fix: apply list to generator objects in analyzer.analyze_lines_mp
12b44e4 
multiprocessing can't pickle generator objects
@r-terada
add parallel output test for connlu, cabocha, json
d6cf134
@r-terada
refactor: impl _OutputWrapper to organize output prints
b3bc859
@r-terada
define pool_obj_mock as fixture
efbf055
@r-terada
refactor: cut process in run() into funcitons
ad59669
@r-terada
Merge pull request #4 from r-terada/feature/refactor_mp
081a445 
refactor command_line.run
@r-terada
refactor: refactor parallel control flow
0a705e9
@hiroshi-matsuda-rit hiroshi-matsuda-rit changed the base branch from develop to feature/refactor_cli October 15, 2021 09:43
@hiroshi-matsuda-rit hiroshi-matsuda-rit merged commit c90b2ec into megagonlabs:feature/refactor_cli Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-terada @hiroshi-matsuda-rit