This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codydaig do you know which change exactly caused this issue? I don't see anything in their changelog that is marked as breaking or very relevant to the error we are seeing. Do you know of a specific issue in the Mongoose repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I was discovering, it's an issue with the mongodb package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely, but looking into their commit history maybe this Automattic/mongoose@9af0d5f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could have been in there. Their commit history is funky to read with the merging of 3.8.x into master between the 4.1.11 and 4.1.12 releases. I'll play and see if I can break it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's definitely an authentication issue. I think we should require the
userandpassoptions to be passed along to theconnectmethod.After reviewing it further last night, I came to the conclusion that this isn't a bug. It appears to be a limitation of how we're handling authentication.
I'm don't have any issues with Mongoose
4.1.12locally when running with the Development env config, because I use local.js to manage thedbsetting; I'm settinguserandpassthere. However, I did run into an issue with running in Test env. Because thedbsetting is not usinguserandpass.Thus, why I added #1011