[hotfix] Lock mongoose version to a working version #1009
Conversation
|
LGTM. |
|
We should consider locking down Mongoose to a specific version going forward. Since mongoose is such a critical part of the project. I've had a lot of issues with certain upgrades in the past. |
[hotfix] Lock mongoose version to a working version
| @@ -44,7 +44,7 @@ | |||
| "lodash": "^3.10.0", | |||
| "method-override": "^2.3.3", | |||
| "mocha": "~1.20.0", | |||
| "mongoose": "^4.0.6", | |||
| "mongoose": "4.1.11", | |||
There was a problem hiding this comment.
@codydaig do you know which change exactly caused this issue? I don't see anything in their changelog that is marked as breaking or very relevant to the error we are seeing. Do you know of a specific issue in the Mongoose repo?
There was a problem hiding this comment.
From what I was discovering, it's an issue with the mongodb package.
There was a problem hiding this comment.
Definitely, but looking into their commit history maybe this Automattic/mongoose@9af0d5f
There was a problem hiding this comment.
Could have been in there. Their commit history is funky to read with the merging of 3.8.x into master between the 4.1.11 and 4.1.12 releases. I'll play and see if I can break it.
There was a problem hiding this comment.
It's definitely an authentication issue. I think we should require the user and pass options to be passed along to the connect method.
After reviewing it further last night, I came to the conclusion that this isn't a bug. It appears to be a limitation of how we're handling authentication.
I'm don't have any issues with Mongoose 4.1.12 locally when running with the Development env config, because I use local.js to manage the db setting; I'm setting user and pass there. However, I did run into an issue with running in Test env. Because the db setting is not using user and pass.
Thus, why I added #1011
MAJOR BUG!!
(the app does not run until this is merged in)
The latest release of mongoose this morning broke changes in the repo. #1008 proves this by removing the cache in travis and forcing travis to use the latest version of mongoose.