Volume projection bounds #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 52.53% 52.91% +0.37%
==========================================
Files 5 5
Lines 1616 1629 +13
==========================================
+ Hits 849 862 +13
Misses 767 767
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
13 tasks
marcomangano
previously approved these changes
Sep 9, 2023
pyspline/pyVolume.py
Outdated
| @@ -830,6 +830,11 @@ def projectPoint(self, x0, nIter=25, eps=1e-10, **kwargs): | |||
| Maximum number of Newton iterations to perform | |||
| eps : float | |||
| Tolerance for the Newton iteration | |||
| volBounds : list of lists | |||
| Optional input to prescribe bounds to the parametric coordinates during the projection. | |||
| The value is a list, that should contain 3 lists with 2 float entries each. | |||
There was a problem hiding this comment.
No comma, replace "should" with "must" as this does not work with anything less than the full list, right?
There was a problem hiding this comment.
Looks like you committed the wrong file 👀
There was a problem hiding this comment.
Thanks for the heads up!
marcomangano
approved these changes
Sep 9, 2023
lamkina
approved these changes
Sep 12, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds optional bounds to the parametric coordinates used during volume projections. Same additions can be done for the surface and curve projections as well. @lamkina and @hajdik can follow the template here.
Expected time until merged
No rush
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable