Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrained adjoint tests with tighter embedding tolerance #317

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Sep 13, 2023

Purpose

The buildbot is failing because of slight mismatches in the adjoint tests as a result of mdolab/pyspline#63. This PR retrains the adjoint tests with a tighter embedding tolerance on the mesh. The tests were trained on the u22-gcc-ompi-latest Docker image.

This should fix the buildbot and also prevent the tests from breaking in the future because of minor changes to pySpline.

Expected time until merged

ASAP

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I checked that the adjoint tests pass with and without the changes in mdolab/pyspline#63.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner September 13, 2023 19:19
@sseraj sseraj requested review from eirikurj and anilyil September 13, 2023 19:19
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #317 (22941de) into main (4cfc3c1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files          13       13           
  Lines        4001     4001           
=======================================
  Hits         1680     1680           
  Misses       2321     2321           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eirikurj eirikurj merged commit 820f182 into main Sep 14, 2023
@sseraj sseraj deleted the fix_test branch September 14, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants