-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTMLElement .offset[height|left|parent|top|width] are stable removed experimental icon #11741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… years now, removed experimental icon
✔️ Deploy Preview for mdn-contributor canceled. 🔨 Explore the source changes: 24bb6d5 🔍 Inspect the deploy log: https://app.netlify.com/sites/mdn-contributor/deploys/61d542381cc55f0007a2bff4 |
Preview URLsFlawsURL:
External URLsURL: No new external URLs |
sideshowbarker
approved these changes
Jan 5, 2022
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
Jan 5, 2022
…ed-js * upstream/main: (286 commits) MediaQueryList removeListener depreciation (mdn#11749) Update index.md to make text time independent (mdn#11748) Corrected typos in multiple pages (mdn#11746) Fix some awkward hyperlink formatting (mdn#11740) HTMLElement .offset[height|left|parent|top|width] are stable removed experimental icon (mdn#11741) Typo (mdn#11742) Fix comments (mdn#11756) Restore line breaks in the `<dd>`s (mdn#11757) Added clarification when property reflects the HTML attribute (mdn#11751) Bump technote-space/get-diff-action from 5.0.2 to 6.0.1 (mdn#11755) Change "validate" to "check" (mdn#11550) Clarify behavior of Array.p.lastIndexOf() fromIndex arg (mdn#11731) FF97 Add experimental feature for ScreenOrientation.lock() (mdn#11705) Correcting one of the example provided (mdn#11709) Adds support for AbortSignal.reason and related items (mdn#11708) Added documentation on missing property (mdn#11721) Bump @mdn/yari from 0.5.4 to 0.6.6 (mdn#11722) Fix: bring gl.FRAMEBUFFER target in line with the spec (mdn#11732) ScreenOrientation.lock() updates for FF97 (mdn#11684) Reword actualBoundingBoxLeft description (mdn#11290) ...
Thanks @sideshowbarker <https://github.com/sideshowbarker> ! I'll start the
updates on other things for the page this week. I have been working closely
to train another dev at my company on semantic native web components. And
extolled the virtue of MDN as being the veritable Encyclopedia Britannica
of web knowledge. I made sure to preface the conversation with what
encyclopedias used to be as I wasn't sure if they are known by people under
30 anymore :)
Accidentally replied with this on a different thread before I realized.
Appologies if you got two notifications.
…On Wed, Jan 5, 2022, 7:50 AM Michael[tm] Smith ***@***.***> wrote:
Merged #11741 <#11741> into main.
—
Reply to this email directly, view it on GitHub
<#11741 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2DEJY4IX3G4MQDPP4ONTUURSDDANCNFSM5LJFR72A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HTMLElement .offset[height|left|parent|top|width] have been stable for many many years. I removed experimental icon from the main content section. This must have either been overlooked or just a simple mistake.
Motivation
It is important to properly show what attrs/properties are and are not experimental to properly encourage or discourage use in applications/websites. When the wrong information is shown, it can lead to confusion or the use/non-use of standards compliant or cross-browser features.
This page in itself needs a lot of work, there are many missing features and attributes. I will edit them and flesh the page out as well. This is not my first contribution, but I want to make sure that I do a small first initial commit and see the lag for merge before deciding if I want to continue with small incremental PRs or a larger one with more updates in a chunk for the next updates.
Supporting details
The pages on the offset* themselves do not say they are experimental, and the browser support is green across the board from extremely old browser versions. Also, nowhere else on MDN are the offset* attributes listed as experimental. I know I have been using them since at least 2009.
Example of offsetHeight on MDN where the page clearly shows it is not experimental and has long looong time browser support, since version 1 of several browsers.
Related issues
None
Metadata