Add note on actualBoundingBoxLeft that the value is calculated reversed #11290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview URLs
FlawsNone! 🎉 External URLsURL: No new external URLs URL: No new external URLs (this comment was updated 2021-12-22 13:02:31.106176) |
|
Just added the comment from source code as a note. Do you mind reviewing the changes? |
jpmedley
requested changes
Dec 20, 2021
jpmedley
approved these changes
Jan 5, 2022
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
Jan 5, 2022
…ed-js * upstream/main: (286 commits) MediaQueryList removeListener depreciation (mdn#11749) Update index.md to make text time independent (mdn#11748) Corrected typos in multiple pages (mdn#11746) Fix some awkward hyperlink formatting (mdn#11740) HTMLElement .offset[height|left|parent|top|width] are stable removed experimental icon (mdn#11741) Typo (mdn#11742) Fix comments (mdn#11756) Restore line breaks in the `<dd>`s (mdn#11757) Added clarification when property reflects the HTML attribute (mdn#11751) Bump technote-space/get-diff-action from 5.0.2 to 6.0.1 (mdn#11755) Change "validate" to "check" (mdn#11550) Clarify behavior of Array.p.lastIndexOf() fromIndex arg (mdn#11731) FF97 Add experimental feature for ScreenOrientation.lock() (mdn#11705) Correcting one of the example provided (mdn#11709) Adds support for AbortSignal.reason and related items (mdn#11708) Added documentation on missing property (mdn#11721) Bump @mdn/yari from 0.5.4 to 0.6.6 (mdn#11722) Fix: bring gl.FRAMEBUFFER target in line with the spec (mdn#11732) ScreenOrientation.lock() updates for FF97 (mdn#11684) Reword actualBoundingBoxLeft description (mdn#11290) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add note on actualBoundingBoxLeft that the value is calculated reversed
Motivation
A value of actualBoundingBoxLeft can be confusing due to it not clarifying how it is calculated in reverse.
Supporting details
See comments on #11116 for more information.
Related issues
Fixes #11116
Metadata