Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated support for scroll-margin/padding-* properties on safari TP #8103

Closed
wants to merge 1 commit into from

Conversation

fabb
Copy link
Contributor

@fabb fabb commented Dec 21, 2020

these properties are supported in Safari Technology Preview.

note that safari still does not support scroll-margin/padding-block/inline-* props
https://webkit.org/blog/11364/release-notes-for-safari-technology-preview-117/

I tested it with Safari TP using this pen, works as expected with both scroll-padding-top and scroll-margin-top: https://codepen.io/fabb64/pen/YzXYQPW

Related:

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

Note that linting fails because Safari 15 is not yet released and therefore not yet contained in browser/safari.json. I'm not sure how to target the TP version of Safari in version_added, please help.
image

…h are supported in Safari Technology Preview

note that safari still does not support scroll-margin/padding-block/inline-* props
https://webkit.org/blog/11364/release-notes-for-safari-technology-preview-117/
@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Dec 21, 2020
@dakur
Copy link
Contributor

dakur commented Dec 21, 2020

Note that linting fails because Safari 15 is not yet released and therefore not yet contained in browser/safari.json. I'm not sure how to target the TP version of Safari in version_added, please help.

I would emphasize this paragraph for the one who reviews it.

@ddbeck ddbeck self-requested a review December 28, 2020 15:24
@ddbeck
Copy link
Collaborator

ddbeck commented Jan 13, 2021

Hi @fabb. Thank you for this PR and your patience while I got to reviewing it.

Unfortunately, I don't have a good answer for you on how to represent this in BCD right now. The short version of the story is that we'll need to wait until Apple has at least issued a beta release before adding this data.

The slightly longer version is that, historically, we've had problems with TP-related data. It's difficult to map a TP version to a general Safari release until Apple actually issues a release. Guessing that a TP feature will appear in the next version number sometimes goes poorly (e.g., guessing incorrectly about whether Apple will issue a point release or a new major version or about which TP marks the cutoff for a full Safari release).

I think the next steps here are to:

  1. Open an issue to track this and record the background information (e.g., tests) that you've provided here.
  2. Reopen this PR when there's a new general Safari version to confirm the changes against.

I'm sorry that it's a bit of a hassle, but without more involvement from Apple in BCD, this is our best workaround. Let me know if you have any questions. Thank you again!

@ddbeck ddbeck removed their request for review January 13, 2021 09:41
@fabb
Copy link
Contributor Author

fabb commented Jan 13, 2021

It’s ok to wait. But how does caniuse.com fill its Safari TP cell data?

@ddbeck
Copy link
Collaborator

ddbeck commented Jan 13, 2021

In addition to using MDN's data, caniuse has its own data too (there may be more to it than that even, I'm not that familiar with how caniuse works under the hood).

@fabb
Copy link
Contributor Author

fabb commented Jan 13, 2021

Hm, but for scroll-margin caniuse.com lists browser-compat-data as source:
94B87CDC-D6BA-4CC9-A50E-992E12D9A585

@dakur
Copy link
Contributor

dakur commented Jan 13, 2021

I guess it just takes last stable version from MDN data and renders it for TP as well. 🤷‍♂️

@ddbeck
Copy link
Collaborator

ddbeck commented Jan 28, 2021

OK, I've opened #8887 to track this until we get a way to track work-in-progress for Safari or Safari actually releases with these features. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants