-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated support for scroll-margin/padding-* properties on safari TP #8103
Conversation
…h are supported in Safari Technology Preview note that safari still does not support scroll-margin/padding-block/inline-* props https://webkit.org/blog/11364/release-notes-for-safari-technology-preview-117/
I would emphasize this paragraph for the one who reviews it. |
Hi @fabb. Thank you for this PR and your patience while I got to reviewing it. Unfortunately, I don't have a good answer for you on how to represent this in BCD right now. The short version of the story is that we'll need to wait until Apple has at least issued a beta release before adding this data. The slightly longer version is that, historically, we've had problems with TP-related data. It's difficult to map a TP version to a general Safari release until Apple actually issues a release. Guessing that a TP feature will appear in the next version number sometimes goes poorly (e.g., guessing incorrectly about whether Apple will issue a point release or a new major version or about which TP marks the cutoff for a full Safari release). I think the next steps here are to:
I'm sorry that it's a bit of a hassle, but without more involvement from Apple in BCD, this is our best workaround. Let me know if you have any questions. Thank you again! |
It’s ok to wait. But how does caniuse.com fill its |
In addition to using MDN's data, caniuse has its own data too (there may be more to it than that even, I'm not that familiar with how caniuse works under the hood). |
I guess it just takes last stable version from MDN data and renders it for TP as well. 🤷♂️ |
OK, I've opened #8887 to track this until we get a way to track work-in-progress for Safari or Safari actually releases with these features. Thank you! |
these properties are supported in Safari Technology Preview.
note that safari still does not support
scroll-margin/padding-block/inline-*
propshttps://webkit.org/blog/11364/release-notes-for-safari-technology-preview-117/
I tested it with Safari TP using this pen, works as expected with both
scroll-padding-top
andscroll-margin-top
: https://codepen.io/fabb64/pen/YzXYQPWRelated:
A checklist to help your pull request get merged faster:
Note that linting fails because Safari 15 is not yet released and therefore not yet contained in
![image](https://user-images.githubusercontent.com/153960/102789762-dad4aa80-43a4-11eb-97ec-9d549c24159a.png)
browser/safari.json
. I'm not sure how to target the TP version of Safari inversion_added
, please help.