Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css.properties.aspect-ratio - Safari Technology Preview 118 added support behind "CSS Aspect Ratio" flag #8847

Closed
andrew-sipes opened this issue Jan 24, 2021 · 6 comments
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action.

Comments

@andrew-sipes
Copy link

What information was incorrect, unhelpful, or incomplete?

Screen Shot 2021-01-24 at 6 07 31 PM

Safari Technology Preview 118 added support for css.properties.aspect-ratio behind the CSS Aspect Ratio flag.

Support is mentioned in release notes: https://developer.apple.com/safari/technology-preview/release-notes/

Support aspect-ratio on non-replaced elements: https://trac.webkit.org/changeset/270551/webkit/

Support aspect-ratio on replaced elements: https://trac.webkit.org/changeset/270618/webkit/

What did you expect to see?

I expected to see Safari marked as having partial support with a flag icon, or perhaps a dropdown like Google Chrome, instructing readers on how to enable the feature for testing.

Did you test this? If so, how?

Yes, I tested it using a CodePen: https://codepen.io/ansipes/pen/QWKXGpB

Screen Shot 2021-01-24 at 6 03 02 PM

Screen Shot 2021-01-24 at 6 04 20 PM

MDN page report details
@queengooborg queengooborg added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jan 25, 2021
@ddbeck ddbeck added the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Jan 29, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Jan 29, 2021

Thanks for reporting this, @ansipes.

Unfortunately, tracking Safari Technology Preview data isn't something we can do just yet, since it hasn't been practical for us to map TP versions to regular Safari versions. See #8103 (comment) for a little more detail.

We can proceed with this when a non-TP Safari beta/final release appears with this feature, giving us a proper version number to enter for this feature. In the meantime, I'm going to label this as blocked. If/when we can move ahead on this, I'd welcome a nudge (or PR). Thank you again!

@ddbeck
Copy link
Collaborator

ddbeck commented Jan 29, 2021

#8802 (comment) also mentioned some details about this.

@andrew-sipes
Copy link
Author

Thanks @ddbeck , I will read those!

I'll keep an eye on it, and if it makes it to Safari 15 Beta or Release, I'll nudge. In the meantime, I'll look at some past PRs and see if I can submit a PR instead of just a nudge!

@bramjoosten
Copy link

bramjoosten commented Jun 16, 2021

@ddbeck bump nudge
https://developer.apple.com/documentation/safari-release-notes/safari-15-beta-release-notes
excited because it will be the last browser starting to support this :)

@Schweinepriester
Copy link
Contributor

I believe this issue can be closed, because #11135/Safari 15 and more importantly that is has been updated already? 0:-)

@queengooborg
Copy link
Contributor

Yep, this has been taken care of in #11135!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action.
Projects
None yet
Development

No branches or pull requests

6 participants
@ddbeck @Schweinepriester @queengooborg @bramjoosten @andrew-sipes and others