Plugins: don't remove pending timeouts on disconnect #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not unregister stuff just because a vehicle timed out, otherwise we leave things unfinished in the case of a connection loss, and a user might wait forever for a callback with a result.
We should not drop timeouts just because a system is lost/timed out.
julianoes
changed the title
JonasVautherin
approved these changes
Feb 12, 2019
|
Merging a demonic PR (666). Very brave. |
|
Isn't it "999" in Australia? I thought everything was inverted there |
|
No, -666 (negative), or i666 (complex) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not get rid of pending timeouts just because the system is reported to be timed out which can happen if we miss a couple of heartbeats in a row due to a lossy connection. We still want to get the notification that our current transaction timed out, otherwise we'll wait for an answer indefinitely (unless the user of the API checks for a timeout again which shouldn't be required).
Found as part of Auterion/mavlink-testing-suite#10.