Test mission protocol with dropped messages #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a fix, otherwise messages are intercepted forever and not reset properly.
This adds a class which takes care of the stuff to randomly drop a certain percentage of the messages.
julianoes
changed the title
This includes the fix for reseting the intercepts.
For debugging purposes it's handy to build and install the Dronecode SDK manually.
We don't clear the mission because that's not implemented yet.
bkueng
reviewed
Feb 12, 2019
This was referenced Feb 12, 2019
This moves the config for how many of the messages to drop to the config.
We are supposed to return true to keep a message, not true to drop it.
This way we should have more reproducible tests because the timing matters less between incoming and outgoing messages.
bkueng
reviewed
Feb 13, 2019
julianoes
commented
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds dropping of incoming and outgoing messages for mission upload/download. The result is that the mission test breaks.