More docker follow-up #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbowerman the trick with does not work with Jenkins, not sure why: |
|
hmm |
julianoes
force-pushed
the
more-docker-fixes
branch
13 times, most recently
from
4d5d415 to
a85a2e0
Compare
It just doesn't work.
julianoes
force-pushed
the
more-docker-fixes
branch
from
a85a2e0 to
c0fa93b
Compare
|
I'm giving up with sudo in docker, we'll just have to do what @JonasVautherin suggested here: |
julianoes
force-pushed
the
more-docker-fixes
branch
from
d2ef347 to
1f83776
Compare
julianoes
force-pushed
the
more-docker-fixes
branch
from
1f83776 to
9498dad
Compare
|
This is good to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to add the local user ID in run-docker.sh.
And we should try to compile the examples in CI.