Jenkinsfile: update to latest docker tag

[julianoes]

This includes sudo.

This is a follow up to #557.

[julianoes]

@dbowerman do you know why travis-ci ends up without permission:
https://travis-ci.org/Dronecode/DronecodeSDK/jobs/432376354#L575-L577

[dbowerman]

@julianoes only that somehow $TRAVIS_BUILD_DIR at that point is not valid. ie the container mounted some dud directory.

[JonasVautherin]

@julianoes: About the examples, I believe that it should be possible to build them without sudo:

1. Install the SDK locally (using INSTALL_PREFIX).
2. Build examples with CPLUS_INCLUDE_PATH=/path/to/installed/include and LIBRARY_PATH=/path/to/installed/lib.
3. Run the examples (possibly with LD_LIBRARY_PATH, but I'm not even sure that's necessary here).

[julianoes]

@JonasVautherin yes that would work but it means the setup is a bit different from the real use case but I guess that's ok.

[dbowerman]

Is the issue the 'user' option being passed to docker. ie. -u stat -c "%u:%g" $TRAVIS_BUILD_DIR ?
Inside the container the users are 'dronecode' and 'root' or more correctly 'dronecode' and 'dronecode using sudo'.

I reckon remove the -u option, which is causing the container to be run with some random user from outside the container.

[julianoes]

I don't understand the error that now happens on Fedora:

dirname: missing operand
Try 'dirname --help' for more information.
/bin/sh: line 0: cd: build/default: Not a directory
Build dir: build/default
/bin/sh: line 0: cd: build/default: Not a directory

[julianoes]

@dbowerman the problem is that the solution with the default dronecode user only works if you're using docker as the user with ID 1000. For everything else you seem to run into troubles.

In my opinion the solution before with just root just worked even though it would sometimes require a sudo make clean to clean up.

[dbowerman]

@julianoes Ah yes. thinking about it, that makes sense. I didn't pick that because I'm the only user (usually uid 1000) on my systems. Give me a day or so to see if theres a solution, otherwise revert I guess.

[dbowerman]

@julianoes this article describes the exact problem and offers a solution.
https://denibertovic.com/posts/handling-permissions-with-docker-volumes/
Do you want to go down that path? or revert?

[julianoes]

@dbowerman oh yes nice, that should work.

[julianoes]

@dbowerman hm, so I tried this and got:

Starting with UID : 9001
useradd: Permission denied.
useradd: cannot lock /etc/passwd; try again later.
su: user user does not exist

Edit: nevermind, I still had the docker run -u argument left over.

[julianoes]

Note: I'm trying to come by without gosu for now, we'll see if that's good enough.

[julianoes]

Forgot to update the docker images, re-running travis.

[julianoes]

Yay, it finally passed. @JonasVautherin please review and merge, so CI is fixed.

[JonasVautherin]

Thanks!