Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation #2732

Merged
merged 37 commits into from
Jun 18, 2019
Merged

Add documentation #2732

merged 37 commits into from
Jun 18, 2019

Conversation

tapaswenipathak
Copy link
Contributor

@tapaswenipathak tapaswenipathak commented May 26, 2019 •
edited
Loading

@tapaswenipathak tapaswenipathak mentioned this pull request May 26, 2019
Closed
@hanzei hanzei requested a review from amyblais May 27, 2019 08:58
@hanzei hanzei added 2: Editor Review Requires review by an editor 1: PM Review Requires review by a product manager labels May 27, 2019
@amyblais amyblais removed the 1: PM Review Requires review by a product manager label May 27, 2019
@amyblais amyblais requested a review from cpanato May 29, 2019 16:31
@amyblais
Copy link
Member

Carlos review: New document - source/install/trouble_mysql.rst.

@tapaswenipathak tapaswenipathak mentioned this pull request May 29, 2019
Closed
jasonblais
jasonblais reviewed May 29, 2019
View reviewed changes
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, else config-settings.rst looks great!

jasonblais
jasonblais approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tapaswenipathak!

@jasonblais jasonblais removed the 1: PM Review Requires review by a product manager label Jun 4, 2019
@amyblais
Copy link
Member

@icelander Do the changes to the config-settings.rst look correct?

@amyblais
Copy link
Member

Hi @tapaswenipathak, wondering if you'd be open to migrating the changes you made to the source/administration/config-settings.rst file to a new pull request as there starts to be merge conflicts in this pull request due to other recent changes we've made to that specific file?

That way we can also get this pull request merged and then continue to review any edits you make to source/administration/config-settings.rst file in a separate pull request.

tapaswenipathak added a commit to tapaswenipathak/docs that referenced this pull request Jun 17, 2019
@tapaswenipathak
Fix few docs tickets
b042282 
ref mattermost#2732 (comment).
tapaswenipathak added a commit to tapaswenipathak/docs that referenced this pull request Jun 17, 2019
@tapaswenipathak
Fix few docs tickets
0ee959c 
ref mattermost#2732 (comment).
@tapaswenipathak tapaswenipathak mentioned this pull request Jun 17, 2019
Merged
@amyblais amyblais added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor 1: Dev Review Requires review by a core commiter labels Jun 18, 2019
@amyblais amyblais removed the request for review from icelander June 18, 2019 13:13
@amyblais amyblais merged commit ced4093 into mattermost:master Jun 18, 2019
@tapaswenipathak tapaswenipathak deleted the minor-docs-fixes branch June 22, 2019 14:08
@amyblais amyblais removed the 3: Reviews Complete All reviewers have approved the pull request label Jun 25, 2019
@tapaswenipathak tapaswenipathak changed the title Minor docs fixes Add documentation Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@jasonblais jasonblais jasonblais approved these changes

@amyblais amyblais amyblais approved these changes

@wiersgallak wiersgallak wiersgallak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tapaswenipathak @amyblais @cpanato @jasonblais @wiersgallak @hanzei