Add instructions for using sockets establishing db #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA. |
|
Hi @tapaswenipathak, Thank you for this contribution! A great way to get involved is by choosing tickets from the docs repository or by adding any new doc pages (just like you mentioned). You can also join our Season of Docs channel on our Community server where you can let our product managers know if you have any questions. For this PR, would you be able to add this new doc section to the table of contents: https://docs.mattermost.com/guides/administrator.html#installing-mattermost? |
tapaswenipathak
force-pushed
the
sockets-db
branch
from
1f3bc05 to
c8bfb23
Compare
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
amyblais
reviewed
May 15, 2019
|
Hi @tapaswenipathak, I just added suggestions for small tweaks for readability. If you agree and apply the changes, I'll then give this to a developer to review as well. Let me know any questions, |
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
Co-Authored-By: amyblais <[email protected]>
|
@amyblais sure! I committed the edits, thanks. |
amyblais
approved these changes
May 15, 2019
amyblais
added
1: Dev Review
amyblais
added
3: Reviews Complete
amyblais
removed
the
3: Reviews Complete
This was referenced May 26, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I didn't find the GSoD'19 tasks open in any repository, the tasks described on the forum are only internal organisation work. I will be closing few tickets from docs repository or any useful addition I find. Great if you can let me know any open task that I can do in GSoD'19 application period. Thanks.