Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate appservice bridge types #1101

Merged
merged 24 commits into from
Sep 15, 2020

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Aug 10, 2020

Paired with matrix-org/matrix-appservice-bridge#218

We've been using our own custom types for matrix-appservice-bridge as a stopgap until the sdk gained types. As the project is starting to sprout types, this PR remove the types which now exist. Unfotunately, this did include a fair amount of tidying.

@Half-Shot Half-Shot changed the title Incorporate appservice bridge types WIP: Incorporate appservice bridge types Aug 14, 2020
@Half-Shot Half-Shot changed the title WIP: Incorporate appservice bridge types Incorporate appservice bridge types Sep 3, 2020
@Half-Shot Half-Shot requested a review from jaller94 September 14, 2020 20:00
@jaller94 jaller94 self-assigned this Sep 15, 2020
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jaller94 jaller94 removed their assignment Sep 15, 2020
@Half-Shot Half-Shot merged commit e4a0bec into develop Sep 15, 2020
@jaller94 jaller94 deleted the hs/incorporate-appservice-bridge-types branch September 15, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants