Various type improvements to improve compatibility with existing bridges #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
reviewed
Sep 4, 2020
| @@ -274,7 +274,7 @@ export class RoomBridgeStore extends BridgeStore { | |||
| return e.remote; | |||
| }) as RemoteRoom[]; | |||
| } | |||
| return entryMap; | |||
| return result; | |||
There was a problem hiding this comment.
:D Nice catch.
(For how long has this been broken? D: )
There was a problem hiding this comment.
Only for the Typescript bits, luckily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a mixed bag of small code changes to ensure compatibility with existing bridges. Care has been taken to lean towards updating the IRC bridge where possible, rather than porting bad behaviours back into this SDK.