Type fixes needed to make matrix-appservice-irc build #196
Conversation
| // eslint-disable-next-line camelcase | ||
| room_id: string; | ||
| // eslint-disable-next-line camelcase | ||
| state_key: string; | ||
| type: string; | ||
| // eslint-disable-next-line camelcase | ||
| event_id: string; | ||
| content: unknown; |
There was a problem hiding this comment.
Is content guaranteed to be an Object or claimed as here unknown? That would require some more type checks in my PR.
There was a problem hiding this comment.
We could probably call it a Record<string,unknown>
There was a problem hiding this comment.
But if that's not guaranteed by the client lib, we'll get errors like the one #155 fixes, where a presumed object may be a string or a number.
There was a problem hiding this comment.
Content should really never be anything other than a object, if it is, we should reject it before insertion?
jaller94
changed the base branch from
j94/typescript-intent+8.0
to
j94/typescript-intent
| // Reject - unexpected content type | ||
| return; | ||
| } | ||
| if (!event.type || !event.state_key) { |
There was a problem hiding this comment.
Just for learning something: This broke the tests. It's not testing if these keys are missing (as claimed by the line below), but if they are truethy. The tests use empty strings, which aren't truethy.
This is a collection of changes needed to make our types work with the IRC bridge. We should either merge this into the parent PR (and subsequently into that one), or find a way to include these changes.