Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bootstrap server error on retry #3579

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Fix bootstrap server error on retry #3579

merged 1 commit into from
Feb 16, 2023

Conversation

Eitu33
Copy link
Contributor

@Eitu33 Eitu33 commented Feb 16, 2023

No description provided.

@Eitu33 Eitu33 changed the base branch from main to testnet_20 February 16, 2023 11:10
@Eitu33 Eitu33 requested a review from AurelienFT February 16, 2023 11:11
@AurelienFT
Copy link
Contributor

Fix #3572

AurelienFT
AurelienFT reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 300 is too magical we could put the number of block we keep in consensus. I think we only keep 10 periods (variable force_keep_final_periods in config.toml) so 10*32 = 320 could be great with a comment explaining this

@Eitu33
Copy link
Contributor Author

Eitu33 commented Feb 16, 2023

I disagree because the force_keep_final_periods is in the dynamic config and that would make the payload limit accessible to the user. We do not want that.

AurelienFT
AurelienFT approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You convinced me that there is no good solution. Let's keep it like that for now and change in the future if needed

@Eitu33 Eitu33 merged commit fd0350a into testnet_20 Feb 16, 2023
@AurelienFT AurelienFT mentioned this pull request Feb 27, 2023
Merged
bors bot added a commit that referenced this pull request Mar 1, 2023
@bors @AurelienFT
@Ben-PH @modship @Eitu33 @sydhds @aoudiamoncef
Merge #3489
f01d16a 
3489: Testnet 20 r=AurelienFT a=AurelienFT

Merged in this testnet:

- #3475 
- #3549
- #3562 
- #3462 
- #3492 
- #3502 
- #3495 
- #3556 
- #3511 
- #3498 
- #3566 
- #3557 
- #3576 
- #3579 
- #3507 
- #3585 
- #3587 
- #3580 
- #3590 
- #3549 
- #3455 
- #3601 
- #3602 
- #3606 
- #3588 
- #3603 
- #3554

Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Ben PHL <[email protected]>
Co-authored-by: Modship <[email protected]>
Co-authored-by: Ben <[email protected]>
Co-authored-by: Eitu33 <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: modship <[email protected]>
Co-authored-by: Moncef AOUDIA <[email protected]>
Co-authored-by: Moncef AOUDIA <[email protected]>
@Ben-PH Ben-PH mentioned this pull request Mar 20, 2023
Closed
28 tasks
@AurelienFT AurelienFT deleted the fix/bootstrap-server-deser-error-on-retry branch May 29, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eitu33 @AurelienFT