Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client error message on bootstrap rejected because of blacklist/whitelist #3511

Merged
merged 8 commits into from
Feb 14, 2023

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Feb 8, 2023

  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

closes #3292

@aoudiamoncef aoudiamoncef requested a review from Eitu33 February 8, 2023 16:14
@aoudiamoncef
Copy link
Contributor Author

@Eitu33

This was quickly tested locally and with two physical nodes

Results with a simple telnet calls:

blacklist:

telnet 192.168.1.190 31245
Trying 192.168.1.190...
Connected to 192.168.1.190.
Escape character is '^]'.
?q??-?h?,Gs?S%?`???9????'?Q[?g????T?T"y+>F?^ox?R????{??" IP 192.168.1.190 is blacklisted.Connection closed by foreign host.

not in whitelist:

telnet 192.168.1.190 31245
Trying 192.168.1.190...
Connected to 192.168.1.190.
Escape character is '^]'.
??S?.
_???;R??M?o?Z?????c?	?t?f??)???cy?a?k?a5?N?f??A?A whitelist exists and the IP 192.168.1.190 is not whitelisted.Connection closed by foreign host.

@aoudiamoncef aoudiamoncef marked this pull request as draft February 8, 2023 18:08
@aoudiamoncef aoudiamoncef marked this pull request as ready for review February 9, 2023 12:58
@aoudiamoncef aoudiamoncef force-pushed the feature/improve-bootsrap-error branch from 5b177fa to 668a498 Compare February 13, 2023 13:38
@aoudiamoncef aoudiamoncef requested a review from Eitu33 February 13, 2023 13:38
@Eitu33
Copy link
Contributor

Eitu33 commented Feb 14, 2023

@aoudiamoncef We can merge without gas costs checks passing for now but the ubuntu CI fails also on unused, please fix before we merge

@aoudiamoncef
Copy link
Contributor Author

@Eitu33 done 💯

@Eitu33 Eitu33 merged commit ddd6727 into testnet_20 Feb 14, 2023
@AurelienFT AurelienFT mentioned this pull request Feb 27, 2023
bors bot added a commit that referenced this pull request Mar 1, 2023
3489: Testnet 20 r=AurelienFT a=AurelienFT

Merged in this testnet:

- #3475 
- #3549
- #3562 
- #3462 
- #3492 
- #3502 
- #3495 
- #3556 
- #3511 
- #3498 
- #3566 
- #3557 
- #3576 
- #3579 
- #3507 
- #3585 
- #3587 
- #3580 
- #3590 
- #3549 
- #3455 
- #3601 
- #3602 
- #3606 
- #3588 
- #3603 
- #3554

Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Ben PHL <[email protected]>
Co-authored-by: Modship <[email protected]>
Co-authored-by: Ben <[email protected]>
Co-authored-by: Eitu33 <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: modship <[email protected]>
Co-authored-by: Moncef AOUDIA <[email protected]>
Co-authored-by: Moncef AOUDIA <[email protected]>
@Ben-PH Ben-PH mentioned this pull request Mar 20, 2023
28 tasks
@AurelienFT AurelienFT deleted the feature/improve-bootsrap-error branch May 29, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants