Remove InMemory implementation #112
Labels
Comments
|
@marcosbarbero WDYT? |
|
Sounds reasonable, let's do that. |
lchayoun
pushed a commit
that referenced
this issue
Sep 24, 2018
lchayoun
pushed a commit
that referenced
this issue
Sep 24, 2018
lchayoun
pushed a commit
that referenced
this issue
Sep 24, 2018
lchayoun
pushed a commit
that referenced
this issue
Sep 24, 2018
marcosbarbero
pushed a commit
that referenced
this issue
Sep 24, 2018
|
Can you give me some guide or example on config bucket4j in memory caches? |
lchayoun
added a commit
to SWCE/spring-cloud-zuul-ratelimit
that referenced
this issue
Jul 2, 2019
* Add Spring Cloud Finchley Support [ci deploy] Add Spring Cloud Finchley support * marcosbarbero#89 A service with different interfaces has different policies (marcosbarbero#90) * marcosbarbero#89 A service with different interfaces has different policies * Get the first IP from X-Forwarded-For list (marcosbarbero#91) * Get the first IP from X-Forwarded-For list * Add unit test for multiple x-forwarded-for * Upgrade version [ci deploy] * Upgrade version [ci deploy] * Fix marcosbarbero#92 * Bump version [ci deploy] * marcosbarbero#97 Fetching username for type USER through a custom implementation - RateLimitUtils should be overridable (marcosbarbero#98) * [ci deploy] 2.0.3.RELEASE * [ci deploy] version 2.0.3.RELEASE * marcosbarbero#99 Properties validation should fail if a policy is configured without limit and without quota (marcosbarbero#100) * [ci deploy] version 2.0.4.RELEASE * Update README.adoc * Redis performance enhancement (marcosbarbero#107) Fixes marcosbarbero#103 * [ci deploy] new release * Adds performance improvement for RedisRateLimiter (marcosbarbero#109) Fixes marcosbarbero#108 * Add License header and minor changes (marcosbarbero#110) Changes: - Add LICENSE Header where it was missing - Minor code/style changes * [ci deploy] new release * marcosbarbero#112 Remove InMemory implementation (marcosbarbero#113) [ci deploy] Fixes marcosbarbero#112 * Remove deprecated properties Fixes marcosbarbero#116 * Next release version 2.2.0 (marcosbarbero#118) [ci deploy] @lchayoun I'm opening this PR just for a discussion about the next release version. As we've removed the deprecated properties with marcosbarbero#117 I think it's better if we move from `2.1.0` to `2.2.0`. Do you agree? Any considerations? * Update dependencies (marcosbarbero#120) * Fix tests configurations (marcosbarbero#123) Fixes the tests configuration removing deprecated properties * Increase codeco (marcosbarbero#124) * Increase codeco * Remove unused import * Minor refactor * Minor refactoring (marcosbarbero#125) * Fix security alerts (marcosbarbero#128) * Minor refactoring * Fix security alerts * Add rate limiting based on user-role evalutation (marcosbarbero#130) Fixes marcosbarbero#127 * Release 2.2.1.RELEASE [ci deploy] * Add role type documentation * Add sample secured application config per user * Update documentation with role type * Feature RateLimitType.METHOD (marcosbarbero#136) Fixes marcosbarbero#135 #### Changes proposed in this pull request: - Add RateLimitType.METHOD - Test RateLimitType.METHOD - Remove unuesed imports in test case by git commit. * Bump version [ci deploy] * spring-cloud-zuul-ratelimit-141 Upgrade Bucket4J and caches versions (marcosbarbero#142) Fixes marcosbarbero#141 #### Changes proposed in this pull request: - Upgrade Bucket4J version to 4.3.0 - Upgrade Hazelcast version to 3.11 - Upgrade Ignite version to 2.7.0 - Upgrade Infinispan version to 9.4.5 * BUG fix: quota never expire (marcosbarbero#147) * Add clientId implementation (marcosbarbero#146) * Add clientId implementation * Add OAuth2 tests * Upgrade Spring Cloud and Spring Boot * Use managed version for spring-security * Trigger build * Revert "Add clientId implementation" (marcosbarbero#148) Reverts marcosbarbero#146 * Custom hide or show header in response (marcosbarbero#150) #### Changes proposed in this pull request: - custom hide or show header in the response * Release [ci deploy] * Migrade autoconfig test to spring boot 2 * Refactor support test classes * Update README.adoc (marcosbarbero#159)[ci skip] * Fixed issue 160 so that it only applies one limit per request. (marcosbarbero#161) * Fixed issue 160 so that it only applies one limit per request and adds breakOnMatch parameter. * Added two unit tests to test basic functionality and an entry in the Policy Properties for breakOnMatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since we support bucket4j, and it has in memory caches support, out InMemory implementation is not necessary and it is also dangerous since it can't be limited in size
The text was updated successfully, but these errors were encountered: