RedisRateLimiter#calcRemainingQuota should use opsForValue instead of boundValueOps

[lchayoun]

the code for calcRemainingQuota should be similar to calcRemainingLimit

[marcosbarbero]

@lchayoun I just noticed that by using this new approach we are no longer setting the reset value as it was before

You can check here for reference.

Should it be rolled back?

[marcosbarbero]

ping @lchayoun

[lchayoun]

Sorry for the delayed response
Since it is not really important, and performance is prefered, I think the code should be as follow:

    @Override
    protected void calcRemainingLimit(Long limit, Long refreshInterval,
                                      Long requestTime, String key, Rate rate) {
        if (limit != null) {
            long usage = requestTime == null ? 1L : 0L;
            rate.setReset(SECONDS.toMillis(refreshInterval));
            Long current = 0L;
            try {
                current = redisTemplate.opsForValue().increment(key, usage);
                // Redis returns 1 when the key is incremented for the first time, and the expiration time is set
                if (current != null && current.equals(1L)) {
                    handleExpiration(key, refreshInterval);
                }
            } catch (RuntimeException e) {
                String msg = "Failed retrieving rate for " + key + ", will return limit";
                rateLimiterErrorHandler.handleError(msg, e);
            }
            rate.setRemaining(Math.max(-1, limit - current));
        }
    }

    private void handleExpiration(String key, Long refreshInterval) {
        try {
            this.redisTemplate.expire(key, refreshInterval, SECONDS);
        } catch (RuntimeException e) {
            String msg = "Failed setting expiration for " + key;
            rateLimiterErrorHandler.handleError(msg, e);
        }
    }