Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight_mode attribute #704

Merged
merged 10 commits into from
Jun 15, 2024
Merged

feat: highlight_mode attribute #704

merged 10 commits into from
Jun 15, 2024

Conversation

marc2332
Copy link
Owner

Depends on #701

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 42.39130% with 53 lines in your changes missing coverage. Please review.

Project coverage is 74.05%. Comparing base (75920c7) to head (1d5e20d).
Report is 2 commits behind head on main.

Current head 1d5e20d differs from pull request most recent head 0a6605e

Please upload reports for the commit 0a6605e to get more accurate results.

Files Patch % Lines
crates/core/src/layout/skia_measurer.rs 18.75% 26 Missing ⚠️
crates/renderer/src/elements/paragraph.rs 0.00% 14 Missing ⚠️
crates/renderer/src/elements/label.rs 0.00% 7 Missing ⚠️
crates/state/src/cursor.rs 16.66% 5 Missing ⚠️
crates/renderer/src/render.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
- Coverage   74.13%   74.05%   -0.09%     
==========================================
  Files         194      196       +2     
  Lines       20320    20387      +67     
==========================================
+ Hits        15065    15098      +33     
- Misses       5255     5289      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/built-in-vertical-alignment-for-text to main June 15, 2024 09:23
@marc2332 marc2332 merged commit 4da5788 into main Jun 15, 2024
3 checks passed
@marc2332 marc2332 deleted the feat/highlight_mode branch June 15, 2024 09:29
This was referenced Jun 26, 2024
This was referenced Jun 29, 2024
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant