Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Built-in vertical alignment for text #701

Merged
merged 3 commits into from
Jun 15, 2024

Conversation

marc2332
Copy link
Owner

No description provided.

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 33 lines in your changes missing coverage. Please review.

Project coverage is 74.08%. Comparing base (d4003c2) to head (01b21ff).

Files Patch % Lines
crates/core/src/layout/skia_measurer.rs 37.03% 17 Missing ⚠️
crates/renderer/src/elements/paragraph.rs 0.00% 8 Missing ⚠️
crates/renderer/src/elements/label.rs 0.00% 7 Missing ⚠️
crates/renderer/src/render.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
- Coverage   74.14%   74.08%   -0.07%     
==========================================
  Files         194      194              
  Lines       20317    20359      +42     
==========================================
+ Hits        15065    15083      +18     
- Misses       5252     5276      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit 7e6d388 into main Jun 15, 2024
6 of 7 checks passed
@marc2332 marc2332 deleted the feat/built-in-vertical-alignment-for-text branch June 15, 2024 09:23
This was referenced Jun 26, 2024
This was referenced Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant