Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove increaseAllowance and decreaseAllowance #2

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

lucas-manuel
Copy link

Description

Removing increase/decrease allowance as they are not in base ERC-20, and attack vector is not really an issue.

Integrations Checklist

  • Have any function signatures changed? If yes, outline below.
  • Have any features changed or been added? If yes, outline below.
  • Have any events changed or been added? If yes, outline below.
  • Has all documentation been updated?

Changelog

Function Signature Changes

Features

Events

Copy link
Contributor

@deluca-mike deluca-mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't remove this, but rather make an extended erc20 contract in this repo.

@lucas-manuel
Copy link
Author

lucas-manuel commented Aug 26, 2021

Closes #3 #4

chore: add no_ouput_timeout to CI config

chore: update timeout
@lucas-manuel lucas-manuel force-pushed the rm-increase-decrease-allowance branch from 322dd0b to 70e63a1 Compare August 30, 2021 01:46
@lucas-manuel lucas-manuel merged commit 0a0f903 into main Aug 30, 2021
@lucas-manuel lucas-manuel deleted the rm-increase-decrease-allowance branch August 30, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants