Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acknowledgements to ERC20.sol #3

Closed
abcoathup opened this issue Aug 26, 2021 · 2 comments
Closed

Add acknowledgements to ERC20.sol #3

abcoathup opened this issue Aug 26, 2021 · 2 comments

Comments

@abcoathup
Copy link

I suggest adding the acknowledgements section from the README to the comments of the ERC20.sol so they don't get lost if the Solidity is copy/pasted

https://github.com/maple-labs/erc-20#acknowledgements

@abcoathup
Copy link
Author

abcoathup commented Aug 28, 2021

Depending how inspired the contract was, you could add a reference to the actual contracts and what license they use.
OpenZeppelin uses MIT, the other two projects use AGPL

See the example in OpenZeppelin:

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/cec4f2ef57495d8b1742d62846da212515d99dd5/contracts/utils/Strings.sol#L15-L16

@lucas-manuel
Copy link

I suggest adding the acknowledgements section from the README to the comments of the ERC20.sol so they don't get lost if the Solidity is copy/pasted

https://github.com/maple-labs/erc-20#acknowledgements

Added thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants