Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-browser polygon tesselation #935

Closed
wants to merge 30 commits into from
Closed

In-browser polygon tesselation #935

wants to merge 30 commits into from

Conversation

mourner
Copy link
Member

@mourner mourner commented Jan 14, 2015

Closes #682. Not ready yet. To do:

  • implement holed polygon -> single ring polygon conversion algorithm as described in FIST paper
  • implement outer/inner rings classification
  • ditch libtess code completely
  • fix artifacts on some complex water polygons
  • solve low-zoom degenerate water polygons issue
  • make sure there are no glaring artifacts browsing through the map
  • fix tests
  • maybe make triangulation code a separate repo https://github.com/mapbox/earcut
  • fix fill antialiasing @ansis
  • fix fill patterns @ansis

@ljbade
Copy link

ljbade commented Jan 15, 2015

+1 for making a seperate lib/repo as people will be interested in a decent triangulation lib. Same for when it gets ported to C++

@mourner mourner force-pushed the earcut branch 2 times, most recently from df78343 to 0dccfa1 Compare January 20, 2015 09:57
@mourner
Copy link
Member Author

mourner commented Jan 20, 2015

@ansis 2 more problems with tesselated fill rendering: anti-aliasing is broken (polygon edges look crappy if you look closely), and fill-pattern is broken.

@jfirebaugh
Merge mapbox/featuresAt-refs-redux
9c9e1a3
@jfirebaugh
StyleLayer
caa5335 
Introduce a StyleLayer class for the in-memory representation
of a style layer.

It handles constant resolution, paint property cascading, and
paint property calculation. The paint functions now accept a
layer as one of the parameters and read all layer properties from
it. This simplifies the rendering flow quite a bit.

The concept of a "bucket" is now something that only the workers
need to know about. The main thread does not create buckets, it
merely stores the buffers and elementGroups on the tile when they
are received from the worker.
@jfirebaugh
Don't mutate layout in the bowels of the worker
b0cd028
@jfirebaugh
Remove unused
05bdb7b
@jfirebaugh
Rationalize style methods
90c0f09 
_cascade ⇢ _resolve (called automatically)
_cascadeClasses ⇢ _cascade (called when classes change)
recalculate ⇢ _recalculate (it's internal-only)
@jfirebaugh
Handle ref layer preceding referent
081a26a
@jfirebaugh
Reimplement ref layer support in featuresAt (#847)
0dee48f 
This is a blend of #901 and #939.

The format for featuresAt results changed again. Instead of
result-per-geometry-cross-layer, each result has a `layers`
array with all layers that contain the feature. Thus avoiding
duplication of geometry and properties in the result set.
@jfirebaugh
Update CHANGELOG
28e0608
@jfirebaugh
Revert to ES5 syntax
da89f70
@jfirebaugh
Fix cov task
d4c0d2b
@jfirebaugh
Skip indexing ref layers without a bucket
8ab5548 
This can happen if the referent layer is skipped due to min/maxzoom.
@mourner
Copy link
Member Author

mourner commented Jan 22, 2015

Need to target another branch so closing. -> #948

@mourner mourner closed this Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mourner @ljbade @jfirebaugh @fnicollet @ansis