Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return ref layers in featuresAt, refs #847 #901

Merged
merged 2 commits into from
Jan 5, 2015
Merged

Return ref layers in featuresAt, refs #847 #901

merged 2 commits into from
Jan 5, 2015

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Dec 20, 2014

#847 :

For example, I'm making a map where I define a road casing in the traditional manner, and then define the road itself via a ref to its casing.

When I featuresAt() at that position, only the casing shows up. I want to get both, while enjoying the performance benefits of ref

@jfirebaugh
Copy link
Contributor

Tests plz!

jfirebaugh added a commit that referenced this pull request Jan 5, 2015
@jfirebaugh
Merge pull request #901 from mapbox/featuresAtRefs
2f334b8 
Return ref layers in featuresAt, refs #847
@jfirebaugh jfirebaugh merged commit 2f334b8 into mb-pages Jan 5, 2015
@jfirebaugh jfirebaugh deleted the featuresAtRefs branch January 5, 2015 22:24
@lbud lbud mentioned this pull request Jan 16, 2015
Merged
jfirebaugh added a commit that referenced this pull request Jan 21, 2015
@jfirebaugh
Reimplement ref layer support in featuresAt (#847)
0dee48f 
This is a blend of #901 and #939.

The format for featuresAt results changed again. Instead of
result-per-geometry-cross-layer, each result has a `layers`
array with all layers that contain the feature. Thus avoiding
duplication of geometry and properties in the result set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbud @jfirebaugh