Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug preventing symbols from being returned by Map#queryRenderedFeatures #3536

Merged
merged 2 commits into from
Nov 3, 2016
Merged

Fix bug preventing symbols from being returned by Map#queryRenderedFeatures #3536

merged 2 commits into from
Nov 3, 2016

Conversation

lucaswoj
Copy link
Contributor

@lucaswoj lucaswoj commented Nov 3, 2016 •
edited
Loading

As of #3478, SymbolBucket no longer inherits from Bucket.

Most of the constructor logic from Bucket was copied to SymbolBucket but the initialization of the SymbolBucket#index property was not. https://github.com/mapbox/mapbox-gl-js/pull/3478/files#diff-621f09c210ab28c3dbf7bc1f0f03c6b2R116

This PR restores the initialization of SymbolBucket#index

fixes #3534

cc @mourner @jfirebaugh

Launch Checklist

jfirebaugh
jfirebaugh approved these changes Nov 3, 2016
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@lucaswoj lucaswoj merged commit 9399143 into master Nov 3, 2016
@lucaswoj lucaswoj deleted the symbol-qrf-3534 branch November 3, 2016 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symbol features are not returned by queryRenderedFeatures
2 participants
@lucaswoj @jfirebaugh