Encapsulate SymbolBucket's unique requirements #3478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SymbolBucket
is in several ways the "odd bucket out":Previously, the
Bucket
base class was generalized such that it could support multiple program interfaces for anyBucket
subtype, and re-create buffers at any time. However, this added complexity to all subtypes other than Symbol.Now,
SymbolBucket
encapsulates its differences:ArrayGroup
/BufferGroup
directly, creating one for each of its three interfaces. In turn, the other bucket types, their corresponding layer rendering functions, and theBucket
base class, can all assume a single program interface.Bucket
base class creates them once, in the constructor.