Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jaybee84/ml-in-rd mansucript #47

Merged
merged 1 commit into from
Jun 12, 2021
Merged

jaybee84/ml-in-rd mansucript #47

merged 1 commit into from
Jun 12, 2021

Conversation

jaybee84
Copy link
Contributor

@jaybee84 jaybee84 commented Jun 4, 2021

adding a new manuscript

adding a new manuscript
Copy link
Member

@dhimmel dhimmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. Due to #48, these changes to the catalog might not take effect immediately.

@dhimmel dhimmel changed the title Update catalog.yml jaybee84/ml-in-rd mansucript Jun 12, 2021
@dhimmel dhimmel merged commit a6b7ef8 into manubot:main Jun 12, 2021
@agitter
Copy link
Member

agitter commented Jun 13, 2021

I noticed that the author annotation [1] is truncated in the catalog
image

This appears to be an issue with Zotero, not the Manubot package

>>> manubot.cite.zotero.web_query('https://jaybee84.github.io/ml-in-rd/')
[{'key': '4X84SF4J', 'version': 0, 'itemType': 'report', 'creators': [{'firstNam
e': 'Jineta', 'lastName': 'Banerjee [1', 'creatorType': 'author'}, {'firstName':
 'Jaclyn N.', 'lastName': 'Taroni [1', 'creatorType': 'author'}, {'firstName': '
Robert J.', 'lastName': 'Allaway', 'creatorType': 'author'}, {'firstName': 'Deep
ashree Venkatesh', 'lastName': 'Prasad', 'creatorType': 'author'}, {'firstName':
 'Justin', 'lastName': 'Guinney *', 'creatorType': 'author'}, {'firstName': 'Cas
ey', 'lastName': 'Greene *', 'creatorType': 'author'}], 'tags': [], 'title': 'Ma
chine learning in rare disease', 'institution': 'Manubot', 'date': '2021-03-02',
 'url': 'https://jaybee84.github.io/ml-in-rd/', 'language': 'en-US', 'libraryCat
alog': 'jaybee84.github.io', 'accessDate': '2021-06-13T11:57:16Z'}]

@jaybee84 if this discrepancy in the Manubot catalog bothers you, you could consider using a different symbol instead of [1].

@dhimmel
Copy link
Member

dhimmel commented Jun 15, 2021

The issue is not the symbol, but that [1] is included in the author name in metadata.yaml like

    name: Jineta Banerjee [1]

Some alternative styles mentioned at manubot/rootstock#312 (comment). Example implementations in greenelab/meta-review@57afd5c and lelaboratoire/rethink-prs-ms@221ed8d.

If you add the following to the front matter source as seen in lelaboratoire/rethink-prs-ms@221ed8d:

<sup>{%- if author.symbol_str is defined -%}{{author.symbol_str}}{%- endif -%}</sup>

Then you should be able to set author.symbol_str in metadata.yaml and this won't get put into the HTML author metadata that Zenodo detects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants