-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding browserifyOptions to arguments #83
Conversation
This will allow any browserify option to be set to the b instance created by Mochify.
Thanks for the pull request. How is this going to work from the command line? I wouldn't want the command line options and the API to diverge. |
Yep will look into that. It should match how the command line works. |
Care to add a basic test that makes sure we don't break this use case in the future? |
No. That one is about passing arguments to the globber. |
Ok great. Will try to get to this soon. Using this plugin on a large project which has afforded me time to fix this. |
Is this PR going in anytime soon? |
@brianlawasdf123 Would you be able to look at the command line options and some basic tests? I'm still willing to merge. |
Apologies all. Projects at work have pulled me away from this. I was only intending to use this plugin from gulp, but our project timeline pulled us away from writing tests. I did not have a chance to go back and look into the command line options. |
If anyone wants to step up and add this feature, I can reopen, or just submit a new PR. The main driver for this was the |
This will allow any browserify option to be set to the b instance
created by Mochify.
#76