Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding browserifyOptions to arguments #83

Closed
wants to merge 2 commits into from
Closed

Adding browserifyOptions to arguments #83

wants to merge 2 commits into from

Conversation

gregorskii
Copy link

This will allow any browserify option to be set to the b instance
created by Mochify.

#76

This will allow any browserify option to be set to the b instance
created by Mochify.
@mantoni
Copy link
Owner

mantoni commented Apr 24, 2015

Thanks for the pull request. How is this going to work from the command line? I wouldn't want the command line options and the API to diverge.

@gregorskii
Copy link
Author

Yep will look into that. It should match how the command line works.

@mantoni
Copy link
Owner

mantoni commented May 27, 2015

Care to add a basic test that makes sure we don't break this use case in the future?

@gregorskii
Copy link
Author

@mantoni, this edit is not complete I have not had a chance to look into the command line argument.

Does #88 accomplish the same goal? Or is similar?

@mantoni
Copy link
Owner

mantoni commented May 27, 2015

No. That one is about passing arguments to the globber.

@gregorskii
Copy link
Author

Ok great. Will try to get to this soon. Using this plugin on a large project which has afforded me time to fix this.

@brianlawasdf123
Copy link

Is this PR going in anytime soon?

@mantoni
Copy link
Owner

mantoni commented Jan 5, 2016

@brianlawasdf123 Would you be able to look at the command line options and some basic tests? I'm still willing to merge.

@gregorskii
Copy link
Author

Apologies all. Projects at work have pulled me away from this. I was only intending to use this plugin from gulp, but our project timeline pulled us away from writing tests. I did not have a chance to go back and look into the command line options.

@mantoni
Copy link
Owner

mantoni commented Feb 23, 2016

If anyone wants to step up and add this feature, I can reopen, or just submit a new PR. The main driver for this was the --path option which was added in 2.17.0.

@mantoni mantoni closed this Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants