Pass '--path' option to browserify. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
closed this
ghost
reopened this
ghost
changed the title
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "mochify", | |||
| "version": "2.16.0", | |||
| "version": "2.16.1", | |||
There was a problem hiding this comment.
Please revert this change. I'll bump the version in the release commit.
|
Thanks for the pull request. Nicely done. One question: Why is the option called |
|
@mantoni It is mainly because I followed convention. There is already a Browserify option called "extensions", which is "extension" in Mochify. It is right above the line that I added in mochify.js file. |
|
Ok, cool. Please revert the package.json change and squash the commits. 👍 |
|
@mantoni Done. |
mantoni
added a commit
that referenced
this pull request
Feb 23, 2016
Pass '--path' option to browserify.
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to pull requests #124 and #83, supporting only the browserify paths option.