Fix: add to cart grouped product when exists a sold out option

[gihovani]

Description (*)

Fix to add to cart grouped product when exists a sold out option.

Fixed Issues (if relevant)

1. [Grouped product] Can´t add simple products to cart if one other is out of stock #22304: [Grouped product] Can´t add simple products to cart if one other is out of stock

Manual testing scenarios (*)

1. enable the option allow to show products without stock
2. grouped product with more sub items
3. at least one sub items have to be without stock (quantity=0)
4. navigate to the PDS of the grouped product
5. add at least on item of any available sub item
6. add the item to the cart

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @gihovani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[gihovani]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @gihovani. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @gihovani, here is your Magento instance.
Admin access: https://i-24955-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[gihovani]

Hi,

i tested it at 2.3-develop and it is reproducible.

[osrecio]

I tested with vanila Magento and with your changes and works properly

[magento-engcom-team]

Hi @osrecio, thank you for the review.
ENGCOM-6115 has been created to process this Pull Request
✳️ @osrecio, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

@gihovani thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Bravo]

✔️ QA passed

[VladimirZaets]

Hi @gihovani. Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.

[gihovani]

Hi @gihovani. Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.

@VladimirZaets, I dont know, how can i create this test...
would you have a similar test for me to get inspired?

[slavvka]

@engcom-Foxtrot Could you please help @gihovani to cover the change with automated test?

[engcom-Golf]

I will take care of test coverage

[engcom-Golf]

@VladimirZaets Well, case covered by unit test.

[engcom-Golf]

@magento run all tests

Fixed

[m2-assistant]

Hi @gihovani, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.