Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Refactor JavsScript for UrlRewrite module edit page. #16992

Conversation

chirag-wagento
Copy link
Contributor

@chirag-wagento chirag-wagento commented Jul 22, 2018

Original Pull Request

#15422
Refactor JavaScript for admin module URL rewrite edit page

Description

Refactor JavaScript for admin module URL rewrite edit page

Fixed Issues (if relevant)

#15356: Refactore javascript for module URL rewrite

Manual testing scenarios

  1. Go to Marketing > URL Rewrites > Edit
  2. Remove Request Path text box value and try to save it.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: UrlRewrite labels Jul 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2457 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: UrlRewrite Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants