Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactore javascript for module URL rewrite #15356

Closed
gelanivishal opened this issue May 19, 2018 · 3 comments
Closed

Refactore javascript for module URL rewrite #15356

gelanivishal opened this issue May 19, 2018 · 3 comments
Labels
Event: dmcdindia Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@gelanivishal
Copy link
Contributor

Use javascript inside *.phtml file it's legacy code that we try to refactor according to Magento way.
For that we have <script type="text/x-magento-init" /> tag, where we declare path to JS file and pass parameters if they are needed

Preconditions

  1. Magento 2.2.4
  2. PHP 7.1.15
  3. MySQL 14.14
  4. Ubuntu

Steps to reproduce

  1. Go to Marketing > URL rewrites > Edit
  2. Remove request path text box value

Expected result

JS Script code should be removed from template file and treated as a separate component

Actual result

JS script is added directly to template file.(Wrong coding format)

@sidolov
Copy link
Contributor

sidolov commented May 25, 2018

Hi @vgelani. Thank you for your report.
The issue has been fixed in #15422 by @patelnimesh1988 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@sidolov sidolov added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 25, 2018
@sidolov sidolov closed this as completed May 25, 2018
@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 5, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 5, 2018

Hi @vgelani. Thank you for your report.
The issue has been fixed in #15747 by @vijay-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@sidolov
Copy link
Contributor

sidolov commented Jul 27, 2018

Hi @vgelani. Thank you for your report.
The issue has been fixed in #16992 by @chirag-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event: dmcdindia Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

3 participants