Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Refactor JavsScript for UrlRewrite module edit page #15747

Merged
merged 1 commit into from
Jun 5, 2018
Merged

[Forwardport] Refactor JavsScript for UrlRewrite module edit page #15747

merged 1 commit into from
Jun 5, 2018

Conversation

vijay-wagento
Copy link

Original Pull Request

#15422
Refactor JavaScript for admin module URL rewrite edit page

Description

Refactor JavaScript for admin module URL rewrite edit page

Fixed Issues (if relevant)

  1. Refactore javascript for module URL rewrite #15356: Refactore javascript for module URL rewrite

Manual testing scenarios

  1. Go to Marketing > URL Rewrites > Edit
  2. Remove Request Path text box value and try to save it.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: UrlRewrite labels Jun 4, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 4, 2018
@sidolov sidolov mentioned this pull request Jun 5, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 6711694 into magento:2.3-develop Jun 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 5, 2018
@VladimirZaets
ENGCOM-1817: [Forwardport] Refactor JavsScript for UrlRewrite module …
7ba1dd2 
…edit page #15747
@magento-engcom-team
Copy link
Contributor

Hi @vijay-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Area: Frontend Component: UrlRewrite Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vijay-wagento @magento-engcom-team @VladimirZaets @patelnimesh1988