-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] #16079 translation possibility for moreButtonText #16229
[Backport] #16079 translation possibility for moreButtonText #16229
Conversation
Hi @orlangur, thank you for the review. |
@Karlasa could you please check that fix actually works for |
@orlangur thanks for the info, will check it in beginning of july. |
@orlangur i double checked and only mistake i did was i did not add new phrase into i18n folder, but otherwise it works for me. Could you specify if that was it? |
@Karlasa not sure if it was it as it worked on other Magento versions, let's trigger recheck with your new change. |
Hi @orlangur, thank you for the review. |
Hi @Karlasa. Thank you for your contribution. |
Description
Added translation possibility for moreButtonText
Fixed Issues (if relevant)
Manual testing scenarios
You need a Configurable Product with a Swatch Product Attribute in Attribute Set
Swatch attribute have color or image attached to each swatch attribute value
This Parent Product have more than three children configured with the Swatch Attribute
In configuration, you need to have in Catalog > Storefront > Swatches per Product defined to 2
In configuration, you need to have in Catalog > Storefront > Show Swatches in Product List defined to Yes
Swatches have "more" text that can be translated
Contribution checklist
Original PR:
#16190